frontend: bottom nav for mobile #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
from
5a8a461 to
e2db87c
Compare
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
from
e2db87c to
47fc7a2
Compare
shonsirsha
commented
Mar 10, 2025
| </svg> | ||
| ); | ||
|
|
||
| export const ExchangeIconSVG = () => ( |
There was a problem hiding this comment.
Using "raw" svg instead of passing it into an image for 2 reasons:
- We can change its fill colour (for Link's active state) easily.
- Also prevents flickering which exists if we're using conditional rendering for svg that are passed into
img. e.g
active ? <BlueIconImage /> : <DarkIconImage />
47fc7a2 to
7cd2f7a
Compare
|
Converting back to draft as we need to figure out regarding the UI if there's no connected accounts available. |
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
from
7cd2f7a to
8a7f1e4
Compare
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
from
8a7f1e4 to
7810812
Compare
thisconnect
requested changes
Mar 19, 2025
frontends/web/src/components/settingsButton/outlined-settings-button.tsx
Show resolved
Hide resolved
frontends/web/src/components/settingsButton/outlined-settings-button.tsx
Show resolved
Hide resolved
frontends/web/src/components/bottom-navigation/bottom-navigation.tsx
Outdated
Show resolved
Hide resolved
frontends/web/src/components/bottom-navigation/bottom-navigation.tsx
Outdated
Show resolved
Hide resolved
frontends/web/src/components/bottom-navigation/bottom-navigation.tsx
Outdated
Show resolved
Hide resolved
thisconnect
reviewed
Mar 19, 2025
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
from
7810812 to
5c4d6a4
Compare
|
Thanks for the review @thisconnect , rebased & made changes PTAL 🙏 |
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
2 times, most recently
from
989da64 to
1511cc2
Compare
|
@thisconnect @jadzeidan , I reduced the font size for the bottom menu label slightly: 
I think it looks better while saving space. EDIT: also adjusted the height, sorry 😄 
|
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
2 times, most recently
from
e3e25e5 to
67d4c60
Compare
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
3 times, most recently
from
d9a6bdd to
67f831c
Compare
|
@thisconnect , thanks! Changes addressed. |
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
from
67f831c to
be7837d
Compare
created a bottom navigation bar and hide the sidebar on mobile for better mobile UX. Also created 2 new routes / page, the "all accounts" route and "more" route to support this new bottom navigation bar.
shonsirsha
force-pushed
the
frontend-mobile-bottom-menu
branch
from
be7837d to
a6d6af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some screenshots for preview:
