qt: fix uri scheme handling on macOS #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qt 6.8, the way custom uri schemes are handled on macOS changed. The commit that changed it is qt/qtbase@664c7ff. Before, the URL would be emitted as a FileOpen event with a QFileOpenEvent object. After this change, it is dispatched to QDesktopServices. Before, QDesktopServices would only be used to register custom schemes while the app was running, but now it also is used when the app is launched with by a URI click (provided the Info.plist entry for it is there of course).
|
Tested and it does work in the app is already running, but if the app is not running, it will open it but not show the AOPP screen :( |
Are you sure that in this case, not another copy of your BitBoxApp in your system (with the bug present) is being opened? |
I'll triple check :) |
bznein
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.