ios: fix safe area #3232
Open
ios: fix safe area #3232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonsirsha
commented
Mar 11, 2025
| @@ -51,8 +51,8 @@ | |||
| .header { | |||
| background-color: var(--color-blue); | |||
| flex-shrink: 0; | |||
| height: var(--header-height); | |||
| padding: 0 var(--space-default); | |||
| padding: 23px var(--space-default); | |||
There was a problem hiding this comment.
I ditched the fixed height and opted for padding-y: 23px, which achieves the same result as height: 70px but is easier to manipulate when factoring in safe-area-inset-top.
shonsirsha
commented
Mar 11, 2025
Comment on lines
+10
to
+12
| padding-top: env(safe-area-inset-top, 0); | ||
| padding-left: env(safe-area-inset-left, 0); | ||
| padding-right: env(safe-area-inset-right, 0); |
There was a problem hiding this comment.
These safe-area-inset-* are built-in variables that provide values which vary based on the device, screen size, and display type (e.g devices with notches / rounded corners)
thisconnect
reviewed
Mar 11, 2025
shonsirsha
force-pushed
the
ios-fix-safe-area
branch
4 times, most recently
from
db69ef7 to
4293f07
Compare
shonsirsha
force-pushed
the
ios-fix-safe-area
branch
from
4293f07 to
08beb50
Compare
benma
reviewed
Apr 8, 2025
frontends/web/index.html
Outdated
Comment on lines
4
to
15
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover" /> | ||
| <meta name="theme-color" content="#000000" /> | ||
| <title>BitBoxApp</title> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="root"></div> | ||
| <script type="module" src="/src/index.tsx"></script> | ||
| </body> | ||
|
|
There was a problem hiding this comment.
Did you remove the indentation on purpose? Please indent again if it was an accident
benma
approved these changes
Apr 8, 2025
benma
requested changes
Apr 8, 2025
shonsirsha
force-pushed
the
ios-fix-safe-area
branch
3 times, most recently
from
ba24b32 to
c1aba6c
Compare
shonsirsha
force-pushed
the
ios-fix-safe-area
branch
7 times, most recently
from
4c12fe1 to
0b3d9b3
Compare
|
rebased |
shonsirsha
force-pushed
the
ios-fix-safe-area
branch
from
0b3d9b3 to
9ef2b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iOS app is bounded within the safe area causing white area / screen to be shown on the top & bottom edges on iPhones & iPads with notches and rounded corners.