Shutdown #3234
Merged
Shutdown #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately the Comments before the `-extra-plugins` without line-break delimiter made it a separate command. The `-` in Makefile means `extra-plugins` is executed ignoring errors. This combination made CI pass without Wayland plugins actually being deployed. Fixes BitBoxSwiss#3229.
benma
force-pushed
the
shutdown
branch
2 times, most recently
from
ed20ced to
46b944a
Compare
Our hidraw udev rule:
```
KERNEL=="hidraw*", SUBSYSTEM=="hidraw", ATTRS{idVendor}=="03eb",
ATTRS{idProduct}=="2403", TAG+="uaccess", TAG+="udev-acl",
SYMLINK+="bitbox02-%n"
```
creates `/dev/bitbox02-N` symlinks (one per HID interface).
The BitBoxApp uses libusb (default backend of karalabe/hid), not
hidraw. However, when a device is opened, the corresponding symlink is
removed, and restored when it is closed (presumably to ensure
exclusive access). Howewer, we never closed the opened devices when
the app closed, leading to the symlink being missing afterwards. This
resulted in apps that use hidraw not being able to connect after the
BitBoxApp connected first, like Sparrow.
This commit calls the backend shutdown on app close, also closing the
opened devices.
Beerosagos
approved these changes
Mar 12, 2025
| @@ -363,8 +363,9 @@ func Shutdown() { | |||
|
|
|||
| log := logging.Get().WithGroup("server") | |||
| if globalShutdown != nil { | |||
| log.Info("Shutdown about to be called") | |||
There was a problem hiding this comment.
nit: is this still needed, or is it a debug leftover?
There was a problem hiding this comment.
I thought it's a helpful line anyway in case Shutdown gets stuck for whatever reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is from #3230