Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make function comment match function name #3239

Merged
merged 1 commit into from
Mar 14, 2025
Merged

chore: make function comment match function name #3239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/coins/btc/transactions/transactions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ func (transactions *Transactions) UpdateAddressHistory(scriptHashHex blockchain.
}
}

// getTransactionsCached requires transactions lock.
// getTransactionCached requires transactions lock.
func (transactions *Transactions) getTransactionCached(
dbTx DBTxInterface,
txHash chainhash.Hash,
Expand Down
2 changes: 1 addition & 1 deletion backend/devices/bitbox02/keystore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ func (keystore *keystore) SignETHMessage(message []byte, keypath signing.Absolut
return signature, nil
}

// SignETHTypedData implements keystore.Keystore.
// SignETHTypedMessage implements keystore.Keystore.
func (keystore *keystore) SignETHTypedMessage(chainId uint64, data []byte, keypath signing.AbsoluteKeypath) ([]byte, error) {
signature, err := keystore.device.ETHSignTypedMessage(chainId, keypath.ToUInt32(), data)
if firmware.IsErrorAbort(err) {
Expand Down
2 changes: 1 addition & 1 deletion backend/rates/history_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func TestHistoryEarliestLatest(t *testing.T) {
assert.Zero(t, updater.HistoryLatestTimestampFiat([]string{"foo", "btc"}, "USD"))
}

// TestLoadDumpUnusableDB ensures no panic when the RateUpdater.historyDB is unusable.
// TestLoadDumpBucketUnusableDB ensures no panic when the RateUpdater.historyDB is unusable.
func TestLoadDumpBucketUnusableDB(t *testing.T) {
updater := NewRateUpdater(nil, "/dev/null")
defer updater.Stop()
Expand Down