Frontend bt connectionstatus styling #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showing a warning looks nicer than plain text.
This allows to confugire a custom icon for actionable items with fallback to the carret. Changed that carret icon is only shown in button mode to visually indicate that this element is clickable. The carret is not needed when the element is not clickable.
- remove unnecessary exports - name TBluetoothState type for better clarity - reformat nested TPeripheral union type
- disable all options when a device is either connected or connecting - show spinner indicator when connecting - show spinner at the bottom when the app is scanning for devices
thisconnect
force-pushed
the
frontend-bt-connectionstatus-styling
branch
from
94ae41d to
0a10373
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit with the spinner replacement has it's own PR/review #3241