Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small account.tsx improvements #3253

Merged
merged 2 commits into from
Mar 27, 2025
Merged

small account.tsx improvements #3253

merged 2 commits into from
Mar 27, 2025

Conversation

benma
Copy link
Contributor

@benma benma commented Mar 25, 2025

No description provided.

benma added 2 commits March 25, 2025 20:03
Status change sets `synced`, `disabled`, `offlineError`, `fatalError`,
which have nothing to do with the balance and list of transactions.
Best practice to handle it in an effect, so it does not matter what
changed the status, but only that it changed.
@benma benma requested a review from thisconnect March 25, 2025 19:04
Copy link
Collaborator

@thisconnect thisconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested LGTM

@benma benma merged commit df0dc05 into BitBoxSwiss:master Mar 27, 2025
9 of 10 checks passed
@benma benma deleted the status2 branch March 27, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants