frontend: cleanup and remove unused sidebar related code #3255
+20
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the early versions of the BitBoxApp the sidebar had to be activelly hidden. This was needed for example during the setup to hide the sidebar. BitBoxSwiss@737c705#diff-dfe1a46131ddaf4054e57c25f15a90037702158127d8959711cbcab68fac0418R161 In newer versions the setup view just covers everything so there is no need to actively hide the sidebar. Most related code has already been removed, but there was still a case in BitBox01 setup and the code in the context, which can now be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the early versions of the BitBoxApp the sidebar had to be activelly hidden. This was needed for example during the setup to hide the sidebar.
737c705#diff-dfe1a46131ddaf4054e57c25f15a90037702158127d8959711cbcab68fac0418R161
In newer versions the setup view just covers everything so there is no need to actively hide the sidebar.
Most related code has already been removed, but there was still a case in BitBox01 setup and the code in the context, which can now be removed.
Before asking for reviews, here is a check list of the most common things you might need to consider: