Ios screenlock #3257
Merged
Ios screenlock #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
LGTM!
Tested with an emulated iPhone through XCode. Both the "cancel" bug and FaceID (https://developer.apple.com/documentation/xcode/testing-complex-hardware-device-scenarios-in-simulator#Test-Face-ID-or-Touch-ID-authentication) work! The only thing I wasn't able to reproduce is that two failed FaceID match fall back to the passcode auth (as mentioned in the commit message), but maybe that is a limitation of the emulator (or mine :D)
WIthout the NSFaceIDUsageDescription Info.plist key, only the passcode could be used. With the key present, the app will ask permission to use FaceID, and if granted, use that, and if not granted, use the passcode. If you re-try the FaceID auth check twice without success, auth falls back to passcode automatically.
When you cancel the screen lock setup during auth, the app would get stuck on an empty 'authenticate' screen. We needed to call MobileserverCancelauth instead so the app handles cancellation properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bznein fyi:
Cancelling an authentication normally should show the 'Authenticate' button to try again, but cancelling the auth when enabling the screen lock in the advanced settings should do nothing (just cancel the screen lock setup). Before this PR, cancelling the setup was buggy.