account.tsx improvements #3262
Merged
account.tsx improvements #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisconnect
approved these changes
Mar 27, 2025
The account component has complicated logic trying to manage state when `code` changes: - reset everything to `undefined` when `code` changes - check that callback responses still match the current code This also prevents us from using the already existing hooks like `useSync`, unless we modify them to accept `depdendencies` and `reset` flags, which would make their use more complicated. Conceptually it is much simpler to remount the account when `code` changes, which automatically takes care of resetting the state and removing subscriptions. Rendering performance is not visibly impacted, as React still only applies the DOM diff.
Instead of manually dealing with loading/syncing it. Simpler code.
Now that we remount the whole component when `code` changes, there is no need to check if the callback response matches the current code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.