factory-setup: Remove C implementation of RTT#1391
Merged
benma merged 1 commit intoBitBoxSwiss:masterfrom Jun 4, 2025
Merged
Conversation
NickeZ
force-pushed
the
nickez/remove-rtt-c-impl
branch
from
bf2bac6 to
f7d22dc
Compare
benma
reviewed
Apr 2, 2025
Collaborator
|
|
NickeZ
force-pushed
the
nickez/remove-rtt-c-impl
branch
from
f7d22dc to
e0c5d2f
Compare
Collaborator
Author
Yeah, fixed |
NickeZ
force-pushed
the
nickez/remove-rtt-c-impl
branch
2 times, most recently
from
4440f12 to
6daf875
Compare
Collaborator
Author
|
rebased |
NickeZ
force-pushed
the
nickez/remove-rtt-c-impl
branch
4 times, most recently
from
87d2ca9 to
da9046d
Compare
Collaborator
Author
|
rebased and fixed an issue with non-debug builds |
NickeZ
force-pushed
the
nickez/remove-rtt-c-impl
branch
2 times, most recently
from
a6278e8 to
1123663
Compare
NickeZ
force-pushed
the
nickez/remove-rtt-c-impl
branch
2 times, most recently
from
75c3adc to
01dcd17
Compare
Collaborator
Author
|
@benma found the bug in non-debug builds, fixed, rebased and pushed, ready for testing again |
The debug builds use the rust implementation of RTT. The two implementations cannot coexist. To be able to build debug builds of the factory-setup the C imeplementation is therefore removed. The factory-setup image is changed to use the second channel for API calls, since the first is used for debug console.
benma
force-pushed
the
nickez/remove-rtt-c-impl
branch
from
01dcd17 to
dff5254
Compare
Collaborator
|
I rebased this resolving two small conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debug builds use the rust implementation of RTT. The two implementations cannot coexist. To be able to build debug builds of the factory-setup the C imeplementation is therefore removed.
The factory-setup image is changed to use the second channel for API calls, since the first is used for debug console.