-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note around localization considerations for recovery phrases in the glossary #753
Conversation
If you're writing Japanese or other languages that are very different from English, then the words in a recovery phrase will look pretty foreign to you. Muun has gotten this feedback and it was a reason why they were more comfortable using output descriptors. Not sure if the glossary is the right place for this, but I think it would be good to add this somewhere. Also wonder if we have any recommendations on what to do instead?
I think it's okay in glossary for now, would you want to add anything more to it, to me this looks like good enough addition, but I've sen you experimenting in Slack, so let me know. |
Posted this on Slack and Twitter to get some more input. |
Good suggestion, definitely need more accessibility content like this. I'd imagine this would suit better in the manual backup page in the daily spending wallet but a footnote on this in the glossary is also a good suggestion. We should tackle adding this to the manual backup page when we get around to revising the daily spending wallet |
Phoenix is working on this, and I opened an issue with Blue Wallet. Due to the lack of current support, the Phoenix crew suggested to start with implementing import of localized recovery phrases. If we can get broad support there, we can implement their creation without having to worry that people will be stuck because they can't import their wallets. BIP39 includes word lists in 10 languages, and there's a separate repo to collaborate around creating more. Not much activity there at the moment. 10 is probably good for now. Looks like this could turn into a campaign like the unified QRs. Considering moving this effort out of this PR into a dedicated collaboration issue in meta. |
Let's do it, I'm keen to help out |
The BlueWallet crew just merged support for this (meaning it supports 10 different languages of wordlists for wallet import now). What are some other wallets we could talk to about this? |
Lets create an issue, make a wallet list in the OP, and start posting issues on their GitHubs to support importing. Looks like its an easy addition based on how fast BlueWallet implemented it. Once they can all import we can then suggest generation. |
Created a collaboration issue for the broader campaign of supporting multi-language recovery phrases. I will clean up this PR so it matches the original intent. Then we can create follow-up PRs for any changes and improvements. |
Added notes to the recovery and manual backup pages. Minor copy tweak to the glossary note.
Pushed a small update to this. There are now hints at supporting multiple languages in three places:
Once more wallets support this, we should add a dedicated paragraph and screen mock-up to the Manual backup page. This will require some more design work to think through details like whether to use the default OS language, how to let users switch languages, etc. And also switched this PR as ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If you're writing Japanese or other languages that are very different from English, then the words in a recovery phrase will look pretty foreign to you (might also have problems typing them back in if you're on a different language keyboard). Muun has gotten this feedback and it was a reason why they were more comfortable using output descriptors.
Not sure if the glossary is the right place for this, but I think it would be good to add this somewhere. Also wonder if we have any recommendations on what to do instead?
🦣Here's the preview🐢