test: remove outdated gettime
test #143
#144
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi @wu-emma
Resolves #143
Removed the stale gettime test.
The test was originally added to check for 32-bit vs 64-bit time mismatches in the mingw toolchain, but it became obsolete after switching to
std::chrono::system_clock
6be319bAny future time-related errors should either trigger undefined behavior sanitizers (ubsan) or fail with existing assertions.
If needed, the test can be reintroduced and extended to cover time handling comprehensively, in coordination with updates to block header timestamp handling (linked to the year 2106 boundary, covered by
_test_y2106)
.Motivation
std::chrono::system_clock
: 6be319b