Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove outdated gettime test #143 #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naftalimurgor
Copy link
Contributor

Summary

Hi @wu-emma

Resolves #143

  • Removed the stale gettime test.

  • The test was originally added to check for 32-bit vs 64-bit time mismatches in the mingw toolchain, but it became obsolete after switching to std::chrono::system_clock 6be319b

  • Any future time-related errors should either trigger undefined behavior sanitizers (ubsan) or fail with existing assertions.

  • If needed, the test can be reintroduced and extended to cover time handling comprehensively, in coordination with updates to block header timestamp handling (linked to the year 2106 boundary, covered by _test_y2106).

Motivation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Clean up tests gettime is outdated
1 participant