Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to front-end part of the app #17

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

0xswakei
Copy link

@0xswakei 0xswakei commented Sep 11, 2022

Summary

  1. This PR adds unit tests for front-end under app/

@0xswakei 0xswakei changed the title Add front-end unit tests Add unit tests to front-end part of the app Sep 12, 2022
@0xswakei
Copy link
Author

Hi @wu-emma
Kindly check this out ( #17 )

Thanks

@van-orton
Copy link
Contributor

the tests unfortunately won't work with updated main branch with web3/Metamask support, could you please update the test code?

@wu-emma
Copy link
Contributor

wu-emma commented Oct 7, 2022

making partial payment, let's finish this so would make one more

@0xswakei
Copy link
Author

0xswakei commented Oct 8, 2022

Hello @wu-emma, @van-orton

Thanks, sure, here's the itinerary:

  1. Sync the main branch with the Metamask feature
  2. Update the add-frontend-tests to cover the new features
  3. Run the tests
  4. update Pull Request accordingly

@wu-emma
Copy link
Contributor

wu-emma commented Oct 18, 2022

hey @0xswakei, how it's going? if any updates please commit them and we merge

@0xswakei
Copy link
Author

hey @0xswakei, how it's going? if any updates please commit them and we merge

Hey @wu-emma
I added more tests, now ready to merge,
My apologies for taking too long,

Thanks

@wu-emma
Copy link
Contributor

wu-emma commented Nov 1, 2022

hey @0xswakei PR looks good, making some more payment, thanks for the contribution!

@0xswakei
Copy link
Author

0xswakei commented Nov 1, 2022

Hey @wu-emma

Thanks: 0xe474564adab5cf48dcfb190fdf61083643c328b789fb1661776831ec0714dd7b
I was hoping it would be total of $1000 USDT since the PR introduces tests into the frontend of the application. I checked the total is $500 USDT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants