Create Makefile #534
Merged
Create Makefile #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to make a makefile such that developers can easily set up their local environments
kjaymiller
reviewed
Oct 19, 2024
|
|
||
| # Install the necessary Ruby gems defined in the Gemfile | ||
| - bundle install | ||
|
|
There was a problem hiding this comment.
What version of Python should be installed?
There was a problem hiding this comment.
Python 3.11.7 will be installed, i have modified the file to reflect this.
There was a problem hiding this comment.
@kjaymiller Kindly review the PR again as she has made the changes requested.
kjaymiller
requested changes
Oct 19, 2024
kjaymiller
reviewed
Oct 20, 2024
kjaymiller
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗: #401
Issue: #401
Type of Change
Description 📋
Developers had to run individual commands in order to set up their local environments. This PR solves the issue by having a makefile that the developers can run instead.
I designed a makefile that developers can easily use to set up their local environments.
This Makefile is designed to set up the environment by installing necessary Ruby and Python versions, dependencies, and configuring pre-commit hooks. It also includes commands to start and stop the Jekyll server.
I chose to choose rbenv because I noticed that it was already being used in the codebase and since I am familiar with it, it made sense to continue its usage. rbenv helps to maintain a ruby version in my repository and I wouldn't need to alter the system wide ruby version.
This Makefile automates the setup and management of this project environment, ensuring that all necessary dependencies and configurations are in place. The change is going to make life easier for other developers by using a one line command to set up their development environment.
Checklist ✅
pre-commit run --allAdditional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.