Add MiMo-V2.5-ASR STT support#719
Conversation
Blaizzy
left a comment
There was a problem hiding this comment.
Could you remove the "MLX" from the name?
The model repo already has tags to identify it as a supported model :)
There was a problem hiding this comment.
No need for a separate file for this.
There was a problem hiding this comment.
You can make this into sanitize method, like we do for every other model
| def _looks_like_mimo(model_name: list[str] | None, config: dict | None) -> bool: | ||
| if config: | ||
| architectures = config.get("architectures") or [] | ||
| if isinstance(architectures, list) and any( | ||
| "MiMoV2ASR" in str(arch) for arch in architectures | ||
| ): | ||
| return True | ||
| for part in model_name or []: | ||
| lowered = part.lower() | ||
| if "mimo" in lowered: | ||
| return True | ||
| return False | ||
|
|
||
|
|
There was a problem hiding this comment.
Please revert all changes to this file except line 16
There was a problem hiding this comment.
The model will be auto discovered with the simple mapping
Blaizzy
left a comment
There was a problem hiding this comment.
Looks good overall just a few nits before we can merge
|
Addressed. Changes in this update:
I also added a small generic Re-validated locally after the change:
|
Signed-off-by: Prince Canuma <prince.gdt@gmail.com>
|
Thanks @ailuntx for the patience! To make it easier, I will make the changes and you can look at what to improve in future PRs. I would suggest asking the agent to follow the format of other existing models and not edit core files like the utils and loading paths. |
|
Updated the branch to keep the MiMo changes within the model integration path. Changes since your comment:
The latest workflow runs are currently marked |
Add
MiMo-V2.5-ASRsupport tomlx-audioSTT.Changes:
mimo_v2_asrmodel familymlx_audio.stt.load()MiMo-Audio-Tokenizerdependency frommlx_manifest.jsonValidation:
intention.wav->Intention.conversational_a.wav-> expected coffee / Kaldi paragraphCloses #718.