Skip to content

Conversation

@apoelstra
Copy link
Contributor

Should unblock #158 and also let us update the webide.

@apoelstra apoelstra requested a review from imaginator as a code owner November 4, 2025 14:52
When we update to rust-simplicity 0.6, we will need to stick an invariant
lifetime (conventionally called 'brand) onto a bunch of types to ensure
that constructed nodes from different type inference contexts are not
mixed.

For the types we own, do this ahead of the actual update, to separate out
the noise from the "real" changes.
Despite the previous commit, this is still pretty noisy, because we need
to put a <'brand> tag onto ProgNode, which is owned by rust-simplicity
and which we couldn't update in the previous commit.
@apoelstra apoelstra force-pushed the 2025-11/release-0.3 branch from 6fa7999 to f76810c Compare November 4, 2025 14:53
Copy link
Contributor Author

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On f76810c successfully ran local tests

@apoelstra
Copy link
Contributor Author

cc @canndrew @delta1

Copy link
Collaborator

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f76810c

Ran tests locally

@apoelstra
Copy link
Contributor Author

Tagged and published.

@apoelstra
Copy link
Contributor Author

Lol github is not letting me push this to master because @delta1 is not a maintainer.

@apoelstra apoelstra merged commit 5c250a4 into BlockstreamResearch:master Nov 7, 2025
9 checks passed
@apoelstra apoelstra deleted the 2025-11/release-0.3 branch November 7, 2025 18:26
@apoelstra
Copy link
Contributor Author

Ok, now he is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants