Backport #271: integer overflow checks #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is possible to ask the bit machine to do arbitrarily large allocations, and to panic the program by overflowing when computing the size of its allocations. This is not the place to do budget checks, but we can at least do some sanity checks. Here we insist that programs not have any types that exceed 2 gigabits (256 megabytes), which will at least prevent explosions. We can revisit it when somebody shows up with a usecase for massive programs.
…tation This commit will fail when put before either of the previous two commits.
|
We expect Clippy failures on this old branch because we aren't pinning our compiler version in CI. |
|
cc @uncomputable I think this will be a quick review and should let us get #280 in. |
|
Had to disable diff-checking the copy of libsimplicity vendored in the depend/ directory, since I can't build the old libsimplicity with a modern nixpkgs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports several integer overflow checks to the currently-released version of 0.3. These can be used to crash rust-simplicity which is making it hard to write regression fuzztests.
Also changes the version to 0.3.1 so we can release immediately.
Should be easy enough to review with
git range-diff pr/271/head...pr/283/head.