doc: fix sage code for deriving alternative generator H #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expression `G.decode('hex')` fails with the following error message
on Sage 9.5:
AttributeError: 'str' object has no attribute 'decode'
Fix that by converting the hex-string to bytes using `bytes.fromhex`.
josibake
approved these changes
May 8, 2024
There was a problem hiding this comment.
ACK 7040a20
Verified by running this using the binder instance for Sage 10.3: https://mybinder.org/v2/gh/sagemath/sage-binder-env/master.
Worth mentioning this is a python2 to python3 change (decoded was removed in python3 iirc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line calculating H (in particular, the expression
G.decode('hex')) fails with the following error message on Sage 9.5:Fix that by converting the hex-string to bytes using
bytes.fromhex.(Noticed while reviewing bitcoin/bitcoin#30048 which picks this code snippet comment up.)