-
Notifications
You must be signed in to change notification settings - Fork 0
Fixes after review #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KyrylR
wants to merge
14
commits into
main
Choose a base branch
from
fix/review
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2025
|
@apoelstra should also review. |
DCD contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure_correct_change_at_index. Fixes Always check current index #4Use input asset to determine option covenent typeissue. Fixes Use input asset to determine option covenent type #2New run:
Done: https://liquid.network/testnet/tx/0ebb7bbe4d2bd72d5bf12e5d65cf5e8816a821c7d9600bd6c8bf3a6d80b9f0ee
Done 2 (cancellation test): https://liquid.network/testnet/tx/0fb896c5620f9415172e02e48c98a3b27380398fe7af8d9d8c3ba974b55607dd
options_taproot_pubkey_gen: 763d23b0bd02337bb267fa1282ae129cef814833e1456644afa3053b9031051f:027f8873a023e321ea3df56a0dcb098479030ee0be868f0f5fe6fba1da8d0bb9f9:tex1pt355pzatlmcxtuasd2rynd0wvmxh8l9g8y8kwk5fv7p0dckszd3sfwjnpv
Done: https://liquid.network/testnet/tx/fe3e22444adb80b5da75aa44cbf4ab52c6b3a6ecbfd9a010e2bc9bb81dfa2a26
options_taproot_pubkey_gen: 7efe3e23414653a1cf58cee8fed04113491ce002e225f28478733548dc51ec66:02b0a4727eefe4cae1748d20cc361b718d06b1bb5347b323ba1d71a617ee483933:tex1pahzvqxjle9zvdzf2gw3q86ps32hxet5tuy0zwdtys7zjg9s529jsf7ul2z
Done 2 (cancellation test): https://liquid.network/testnet/tx/6ca00f7cab1db9e7ed09e9fbc446c4fcc83074b67d83faa15a02510183793b02
Done: https://liquid.network/testnet/tx/c71f1901a96d2f843eca628e595f97649a080668229d8800a2ca094051b77e5d
Done 2 (cancellation test): https://liquid.network/testnet/tx/9480d87d08f6dc8c4213548d159c40d5f93f5068e59c06e174e21a7d50a75dd2
Done: https://liquid.network/testnet/tx/ceea050ab1da532ce4e60241eb948cc4a2ffaec8a320c494dc460ed75b376aae
Done: https://liquid.network/testnet/tx/4e07ca1481d6e8b39c29c89e784f436333e50596288af5f65f9a7151c5b8e19c
Done: https://liquid.network/testnet/tx/07ecfc3fb98db1693b2721c5efeea1a0bb348b4bc6ff4ef57526e9d5d8e4867f
Done: https://liquid.network/testnet/tx/86c10905302c54812af0bbcae917b6458a1108ef0292634eaa1dbb9340aa870f