Make primitive.h functions indirect #292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original plan here was to build different Simplicity primitives (e.g. Elements and Bitcoin), which are selected at link time.
However, we would like to link multiple sets of primitives into Haskell for testing purposes. This means we will need different names for the Bitcoin and Elements to bind them.
To support this we turn the primitive.h functions into callbacks for the various specific primitive implementations.
Various functions are rearranged to support the removal of primitive.h and make the pairing of .c file implementing .h header files more consistent. It should now be the case that each .c files implement exactly the declairations of one .h file.