feat: add Giphy GIF provider with selectable provider and in-app API keys#3050
Open
dgshue wants to merge 1 commit into
Open
feat: add Giphy GIF provider with selectable provider and in-app API keys#3050dgshue wants to merge 1 commit into
dgshue wants to merge 1 commit into
Conversation
Member
|
We are likely dropping default in-app GIF keyboard support in favor of gif insertion from the win+. menu, but will consider this for people who want to bring their own keys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GIF search is hardcoded to Tenor and depends on a build-time
TENOR_API_KEY. Users building from source — or who prefer Giphy — can't choose a provider or supply their own key without rebuilding.Solution
gifProvidersetting ("tenor" | "giphy" | "none", defaults to"tenor"— existing behavior unchanged)tenorApiKeyOverride/giphyApiKeyOverridesettings to paste your own keys at runtime (falls back to the compiled-in key when blank)showApiKeyDialog()with obscured input + provider sign-up linkgiphy_get: ^3.6.1+1No changes to existing Tenor behavior when defaults are kept.
Testing
Built and manually tested on Windows desktop:
Screenshots
N/A — happy to add on request.