Make xml version declaration optional regex #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes an issue where the doctype declaration is not stripped when the xml version declaration is missing from the exported `.enex` file. When the `DOCTYPE` declaration is left in, we get `REXML::ParseException: Declarations can only occur in the doctype declaration.` raised exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes an issue where the doctype declaration is not stripped when the
?xmlversion declaration is missing from the exported.enexfile. When theDOCTYPEdeclaration is left in, we getREXML::ParseException: Declarations can only occur in the doctype declaration.raised exception as seen in this issue.
The regex pattern is modified to make the
<?xml>part optional.