Conversation
- Replace axum DefaultBodyLimit with tower_http RequestBodyLimitLayer - Set global limit to 50 MB for all routes - This provides a more consistent approach than path-specific limits Co-authored-by: Sam Lijin <sam@boundaryml.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request Template
Thanks for taking the time to fill out this pull request!
Issue Reference
Please link to any related issues
Changes
Please describe the changes proposed in this pull request
This PR implements a global request body limit for the BAML runtime server.
axum::extract::DefaultBodyLimitwithtower_http::limit::RequestBodyLimitLayerto apply a global limit.tower-httpdependency with thelimitfeature toengine/baml-runtime/Cargo.toml.engine/baml-runtime/src/cli/serve/mod.rsto reflect these changes.Testing
Please describe how you tested these changes
cargo test -p baml-runtime --libwhich resulted in all 147 tests passing.cargo fmtfor code formatting.Screenshots
If applicable, add screenshots to help explain your changes
[Add screenshots here...]
PR Checklist
Please ensure you've completed these items
cargo fmt)Additional Notes
Add any other context about the PR here
This change addresses the need for a global request body limit, replacing a more specific or default limit with a consistent approach across the server.
Slack Thread