engine_typescript(fix): export HTTP request/response runtime symbols#3237
engine_typescript(fix): export HTTP request/response runtime symbols#3237miguelcsx wants to merge 2 commits intoBoundaryML:canaryfrom
Conversation
|
@miguelcsx is attempting to deploy a commit to the Boundary Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds HTTPRequest, HTTPResponse, and SSEResponse to the TypeScript language client public API, updates type re-exports to alias native implementations, and introduces a Node vs. browser import guard that throws on browser access for these HTTP/SSE symbols. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can validate your CodeRabbit configuration file in your editor.If your editor has YAML language server, you can enable auto-completion and validation by adding |
2f58ba9 to
ea67a2e
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1f4e5374-a8be-4a41-b5eb-81ea16f67acf
📒 Files selected for processing (2)
engine/language_client_typescript/index.jsengine/language_client_typescript/package.json
|
ty for the fix, but we need to change the actual |
I didn't realize those files were autogenerated. I've updated the .ts source and regenerated the .js files. Thanks for the catch. |
- add missing runtime exports for HTTPRequest, HTTPResponse, and SSEResponse - fix ESM import failure in generated BAML clients
- Fix exists on ts files, instead on autogenerated js - avoid overrides of the code when generation
5e5c7ab to
2471450
Compare
This PR fixes a packaging issue in
@boundaryml/bamlwhere the TypeScript package entrypoint did not export several runtime symbols that generated clients expect to import.Referenced here: Discord Message
Why this fixes the issue
The change adds the missing runtime exports in
engine/language_client_typescript/typescript_src/index.tsfor:HTTPRequestHTTPResponseSSEResponseAfter this change:
What changed
0.220.1Developer impact
Summary by CodeRabbit
New Features
Chores