Skip to content

Simplify QueryTemplate::applyFilter()#28

Open
szepeviktor wants to merge 2 commits intoBrain-WP:masterfrom
szepeviktor:fix/simple
Open

Simplify QueryTemplate::applyFilter()#28
szepeviktor wants to merge 2 commits intoBrain-WP:masterfrom
szepeviktor:fix/simple

Conversation

@szepeviktor
Copy link
Copy Markdown
Contributor

@szepeviktor szepeviktor commented May 18, 2022

After trying to understand this method, I'm sorry to report but my 🧠 brain hurt.

This PR makes it easy to understand and maintain. Please see decreasing Complexity below.

@szepeviktor szepeviktor marked this pull request as draft May 18, 2022 01:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2022

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.50%. Comparing base (15564dc) to head (6e8332e).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/QueryTemplate.php 81.25% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
- Coverage     78.13%   77.50%   -0.64%     
+ Complexity      230      227       -3     
============================================
  Files            30       30              
  Lines           439      440       +1     
============================================
- Hits            343      341       -2     
- Misses           96       99       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@szepeviktor szepeviktor marked this pull request as ready for review May 18, 2022 01:52
@szepeviktor
Copy link
Copy Markdown
Contributor Author

@gmazzap friendly ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants