Fix race condition for double startRound() during correct guess (#2080)

* Fix race condition for double startRound() during correct guess * Add prevalidation delay for test runner stages
Brainicism · Apr 14, 2024 · fff8e05 · fff8e05
1 parent f6085f1
commit fff8e05
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 9 deletions.
diff --git a/src/structures/game_session.ts b/src/structures/game_session.ts
@@ -243,22 +243,29 @@ export default class GameSession extends Session {
      * Ends an active GameRound
      * @param isError - Whether the round ended due to an error
      * @param messageContext - An object containing relevant parts of Eris.Message
+     * @param gameRound - The round to end
      */
     async endRound(
         isError: boolean,
         messageContext: MessageContext,
+        gameRound?: GameRound,
     ): Promise<void> {
+        // if round ending due to correct song guess, ensure that we are operating on the provided
+        // game round to ensure we don't end the same round twice (since this.round is modified)
+        let round = gameRound ?? this.round;
+        if (!round) {
+            round = this.round;
+        }
+
         // wait and accept multiguess results
         await delay(
             this.multiguessDelayIsActive(this.guildPreference)
                 ? this.guildPreference.getMultiGuessDelay() * 1000
                 : 0,
         );
 
-        const round = this.round;
-
         // ensure that only one invocation can proceed
-        if (round === null || round.finished) {
+        if (!round || round.finished) {
             return;
         }
 
@@ -394,6 +401,8 @@ export default class GameSession extends Session {
         } else if (this.gameType === GameType.SUDDEN_DEATH && !isCorrectGuess) {
             await this.endSession("Sudden death game ended", false);
         }
+
+        await this.startRound(messageContext);
     }
 
     /**
@@ -565,18 +574,15 @@ export default class GameSession extends Session {
                 return;
             }
 
-            // mark round as complete, so no more guesses can go through
-            await this.endRound(false, messageContext);
+            this.stopGuessTimeout();
             this.correctGuesses++;
+            // mark round as complete, so no more guesses can go through
+            await this.endRound(false, messageContext, round);
 
             // update game session's lastActive
             await this.lastActiveNow();
 
-            this.stopGuessTimeout();
-
             await this.incrementGuildSongGuessCount();
-
-            await this.startRound(messageContext);
         } else if (this.isMultipleChoiceMode() || this.isHiddenMode()) {
             // If hidden or multiple choice, everyone guessed and no one was right
             if (

diff --git a/src/test/end-to-end-tests/test-runner-bot.ts b/src/test/end-to-end-tests/test-runner-bot.ts
@@ -330,6 +330,10 @@ async function evaluateStage(messageResponse?: {
 
     log(`STAGE ${CURRENT_STAGE.stage} | Validating stage`);
     const stageOutputValidator = testStage.responseValidator;
+    if (testStage.prevalidationDelay) {
+        await delay(testStage.prevalidationDelay);
+    }
+
     if (
         stageOutputValidator(
             messageResponse?.title!,

diff --git a/src/test/end-to-end-tests/test_suites/gameplay_test.ts b/src/test/end-to-end-tests/test_suites/gameplay_test.ts
@@ -216,6 +216,7 @@ const PLAY_TEST_SUITE: TestSuite = {
                 console.log(`voiceMembers: ${voiceMembers.join(", ")}`);
                 return !voiceMembers.includes(process.env.BOT_CLIENT_ID!);
             },
+            prevalidationDelay: 3000,
             expectedResponseType: KmqResponseType.NONE,
         },
     ],

diff --git a/src/test/end-to-end-tests/test_suites/test_suite.ts b/src/test/end-to-end-tests/test_suites/test_suite.ts
@@ -12,6 +12,7 @@ export default interface TestSuite {
             client?: Eris.Client,
         ) => boolean;
         expectedResponseType: KmqResponseType;
+        prevalidationDelay?: number;
         preCommandDelay?: number;
     }[];
     cascadingFailures: boolean;