Skip to content

#3666 and #3667 sp_BlitzLock fixes #3672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

#3666 and #3667 sp_BlitzLock fixes #3672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60cee45
look for existing output table in sys.schemas
rodik Jul 16, 2025
802f35f
add explicit schema to synonym
rodik Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions sp_BlitzLock.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,19 +589,17 @@ BEGIN
@StringToExecute =
N'SELECT @r = o.name FROM ' +
@OutputDatabaseName +
N'.sys.objects AS o WHERE o.type_desc = N''USER_TABLE'' AND o.name = ' +
N'.sys.objects AS o inner join ' +
@OutputDatabaseName +
N'.sys.schemas as s on o.schema_id = s.schema_id WHERE o.type_desc = N''USER_TABLE'' AND o.name = ' +
QUOTENAME
(
@OutputTableName,
N''''
) +
N' AND o.schema_id = SCHEMA_ID(' +
QUOTENAME
(
@OutputSchemaName,
N''''
) +
N');',
N' AND s.name =''' +
@OutputSchemaName +
N''';',
@StringToExecuteParams =
N'@r sysname OUTPUT';

Expand Down Expand Up @@ -843,12 +841,12 @@ BEGIN
)
BEGIN
RAISERROR('Found synonym DeadlockFindings, dropping', 0, 1) WITH NOWAIT;
DROP SYNONYM DeadlockFindings;
DROP SYNONYM dbo.DeadlockFindings;
END;

RAISERROR('Creating synonym DeadlockFindings', 0, 1) WITH NOWAIT;
SET @StringToExecute =
N'CREATE SYNONYM DeadlockFindings FOR ' +
N'CREATE SYNONYM dbo.DeadlockFindings FOR ' +
@OutputDatabaseName +
N'.' +
@OutputSchemaName +
Expand All @@ -870,12 +868,12 @@ BEGIN
)
BEGIN
RAISERROR('Found synonym DeadLockTbl, dropping', 0, 1) WITH NOWAIT;
DROP SYNONYM DeadLockTbl;
DROP SYNONYM dbo.DeadLockTbl;
END;

RAISERROR('Creating synonym DeadLockTbl', 0, 1) WITH NOWAIT;
SET @StringToExecute =
N'CREATE SYNONYM DeadLockTbl FOR ' +
N'CREATE SYNONYM dbo.DeadLockTbl FOR ' +
@OutputDatabaseName +
N'.' +
@OutputSchemaName +
Expand Down Expand Up @@ -4105,7 +4103,7 @@ BEGIN

RAISERROR('Finished at %s', 0, 1, @d) WITH NOWAIT;

DROP SYNONYM DeadLockTbl;
DROP SYNONYM dbo.DeadLockTbl;

SET @d = CONVERT(varchar(40), GETDATE(), 109);
RAISERROR('Findings to table %s', 0, 1, @d) WITH NOWAIT;
Expand Down Expand Up @@ -4135,7 +4133,7 @@ BEGIN

RAISERROR('Finished at %s', 0, 1, @d) WITH NOWAIT;

DROP SYNONYM DeadlockFindings; /*done with inserting.*/
DROP SYNONYM dbo.DeadlockFindings; /*done with inserting.*/
END;
ELSE /*Output to database is not set output to client app*/
BEGIN
Expand Down