rollup of several outstanding PRs + bump MSRV to Rust 1.73 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pedantic lint, but it removes a transmute where a cast will do. The code is safe for the same reasons the transmute is safe: `BStr` is a repr transparent wrapper around `[u8]`.
Add instances for `[u8; N]` and `&[u8; N]`, for convenience. Closes #191
A build on nightly currently produces this:
warning: elided lifetime has a name
--> src/escape_bytes.rs:15:43
|
14 | impl<'a> EscapeBytes<'a> {
| -- lifetime `'a` declared here
15 | pub(crate) fn new(bytes: &'a [u8]) -> EscapeBytes {
| ^^^^^^^^^^^ this elided lifetime gets resolved as `'a`
|
= note: `#[warn(elided_named_lifetimes)]` on by default
Fix that by changing `EscapeBytes` to `Self`, which constrains the
lifetime.
Closes #192
This isn't strictly necessary, but I'm doing a minor version bump and might as well move the trains along.
BurntSushi
changed the title
|
This PR is on crates.io in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rollup of a few outstanding PRs.
I'll do a minor version bump, so I'll take advantage of that opportunity and bump the MSRV to Rust 1.73.
Closes #160, Closes #189, Closes #191, Closes #192, Closes #197