Refactor and update parsing#9
Draft
moofMonkey wants to merge 19 commits intoButterflyStats:masterfrom
Draft
Conversation
moofMonkey
commented
Oct 14, 2023
|
|
||
| private: | ||
| uint8_t size_ = 0; | ||
| std::array<uint16_t, 7> ar{}; |
Author
There was a problem hiding this comment.
Even though current DEFAULT_MAX_PATH_DEPTH is 10, no parsers currently handle this.
Having only 7 path elements gives us perfect 16 byte fieldpath size/alignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
Fixes #8
fieldpathcodeproperty#typetofs_infoflattened_serializerinstead of usingstd::vector/std::unordered_mapto reduce RAM and CPU usagem_fGameTimelogic -m_fGameTimewas removed in favor of tick-based time calculationBUTTERFLY_THREADSAFEstd::vectorwithllvm::SmallVectorinentity::parseWould it be fine if I add Google/LLVM-styled clang-format?
If so, is
SpacesInParentheses: trueworth preserving in butterfly code?This might introduce problems if array size is parsed incorrectly, but could theoretically reduce RAM/CPU usage.
Known problems:
butterfly::parserdue to global object pools heap use-after-free inentity::~entityThis affects 03-props, 06-events and 07-combatlog
entity_classesclass_idshould either assert or returnUINT32_MAXon lookup failureNext PRs TODO: