Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: YL-43-GitWorkflow-BugFix-WrongLabels-Back #17

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

C-Alexis4414
Copy link
Owner

@C-Alexis4414 C-Alexis4414 commented Sep 25, 2024

WHAT

  • Labeler action has upgraded from v4 to v5 for apply config in labeler.yml file.
  • Secret token for Github action has defined in settings and added to repository.
  • Documentation label has added

WHY

Fix the bug where all labels had affected while the files concerned had not been changed.

HOW

  • Upgraded from version 4 to 5
- uses: actions/labeler@v5
  • I consulted the Anoosh blog medium for the Github token settings (see the link of reference in resources)
  • Tested with other repository.
  • I found a label type error during the verification on the current branch. This is because the action must be on the default branch, main in our case (see the link of the issue consulted in the Resources section)
  • Check will fail for this PR but will be functional once this branch merged

Link to Jira ticket

YL-43 GitWorkflow-BugFix-WrongLabels-Back

Checklist

  • Tested
  • Documented or commented
  • Search for duplicates code or PRs or issues
  • Blocked
  • WIP

Blocked

N/A

WIP

N/A

Resources

Seetings of Github token :
Automate GitHub PR Labeling with the Labeler Action
Issue in repository of Labeler :
Error: found unexpected type for label 'xxx' (should be array of config options)

┆Issue is synchronized with this Jira Task by Unito

@github-actions github-actions bot added size/XS ci/cd Continuous integration and delivery tables crud tests gitWorkflow and removed size/XS labels Sep 25, 2024
@C-Alexis4414 C-Alexis4414 added bug Something isn't working and removed ci/cd Continuous integration and delivery tables crud tests labels Sep 25, 2024
@C-Alexis4414 C-Alexis4414 linked an issue Sep 25, 2024 that may be closed by this pull request
@github-actions github-actions bot added ci/cd Continuous integration and delivery tables crud tests size/S labels Sep 25, 2024
@C-Alexis4414 C-Alexis4414 removed ci/cd Continuous integration and delivery tables crud tests labels Sep 25, 2024
@C-Alexis4414
Copy link
Owner Author

I took the opportunity to define the limit when the number of lines changed in the code is too large for easy reading in a pr.

@github-actions github-actions bot added ci/cd Continuous integration and delivery tables crud labels Sep 26, 2024
@github-actions github-actions bot added the tests label Sep 26, 2024
@C-Alexis4414
Copy link
Owner Author

Security label added in anticipation of the next branch on strengthening security with CSRF token.

Copy link
Collaborator

@accardigianni accardigianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@accardigianni accardigianni merged commit 2c9b2cf into main Oct 4, 2024
6 checks passed
@accardigianni accardigianni deleted the YL-43-GitWorkflow-BugFix-WrongLabels-Back branch October 4, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd Continuous integration and delivery gitWorkflow size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Fix bug of wrong label assignment in backend
2 participants