javascript to export table data as .xls file#83
Draft
vinay-easwaran wants to merge 22 commits intomasterfrom
Draft
javascript to export table data as .xls file#83vinay-easwaran wants to merge 22 commits intomasterfrom
vinay-easwaran wants to merge 22 commits intomasterfrom
Conversation
This reverts commit 796ca7f.
mrysav
reviewed
Mar 9, 2024
Collaborator
mrysav
left a comment
mrysav
left a comment
There was a problem hiding this comment.
I like what you have so far and I thought your demos this morning went really well! Thank you for the progress so far!
Comment on lines
+56
to
+57
| <script src="//ajax.googleapis.com/ajax/libs/jquery/2.2.4/jquery.min.js"></script> | ||
| <script src="//cdn.rawgit.com/rainabba/jquery-table2excel/1.1.0/dist/jquery.table2excel.min.js"></script> |
Collaborator
There was a problem hiding this comment.
I'd recommend downloading these to the BLIS folder and putting them somewhere so they can be accessed locally. There is a bunch of javascript already in htdocs/js for this reason.
Additionally - using these libraries is fine, but please test on the ancient bundled version of Firefox (5.x I think?) with the BLIS Windows version to make sure the libraries and your code works there as well.
Comment on lines
3
to
8
| # TAKE NOTE! | ||
| # For this to work properly, you need to make sure that _all_ of these | ||
| # required files are not outputting anything to the browser. | ||
| # https://github.com/PHPOffice/PHPExcel/blob/1.8/Documentation/markdown/Overview/08-Recipes.md#http-headers | ||
| # Ensure that these files are _not_ encoded as "UTF-8 with BOM" (Byte Order Mark) | ||
| # since that also counts. They should be "UTF-8". |
Collaborator
There was a problem hiding this comment.
Similar comments for this file, as above.
htdocs/includes/page_elems.php
Outdated
Comment on lines
807
to
812
| // $query = "(SELECT CONCAT(table_name, ':', column_name) as field_name FROM | ||
| // Information_schema.columns where table_name = 'patient') UNION | ||
| // SELECT CONCAT(table_name, ':', column_name) as field_name FROM | ||
| // Information_schema.columns where table_name = 'specimen') UNION | ||
| // (SELECT CONCAT(table_name, ':', column_name) as field_name FROM | ||
| // Information_schema.columns where table_name = 'specimen_type');"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| // $query = "(SELECT CONCAT(table_name, ':', column_name) as field_name FROM | |
| // Information_schema.columns where table_name = 'patient') UNION | |
| // SELECT CONCAT(table_name, ':', column_name) as field_name FROM | |
| // Information_schema.columns where table_name = 'specimen') UNION | |
| // (SELECT CONCAT(table_name, ':', column_name) as field_name FROM | |
| // Information_schema.columns where table_name = 'specimen_type');"; |
Better to not commit commented code
|
|
||
| $("#report_content_table5").table2excel({ | ||
| // exclude: ".excludeThisClass", | ||
| name: "Daily Log - Patients", |
Collaborator
There was a problem hiding this comment.
Can probably replace this with a localized string from somewhere
Co-authored-by: Mitchell Rysavy <mitchell.rysavy@gmail.com>
Co-authored-by: Mitchell Rysavy <mitchell.rysavy@gmail.com>
Co-authored-by: Mitchell Rysavy <mitchell.rysavy@gmail.com>
read only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.