Fix Civ3MenuButton visual multi-select issue#921
Merged
ajhalme merged 1 commit intoC7-Game:Developmentfrom Mar 28, 2026
Merged
Conversation
stavrosfa
approved these changes
Mar 26, 2026
Contributor
stavrosfa
left a comment
stavrosfa
left a comment
There was a problem hiding this comment.
Thanks, that seems to work well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #898.
Removing the alternative route to "effective press" results in the visual update doing the right thing. We want to only change to the "active" button texture when we have a true click, which in "active on release"
ActionModeis what we want.I can't think of a case where the current behaviour is desired, but if we want Civ3MenuButton to change state already on the press down, we probably want to change things up so that the
ActionMode("active on press" vs "active on release") is made use of.