Support broadside attack facing

[richardspink2]

Summary

• Import the Civ3 TurnToAttack flag into unit prototype data.
• Use that flag to rotate attack animations counter-clockwise for broadside units while keeping combat bonuses, retreats, and defensive bombard logic based on the real attack direction.
• Add rotateBeforeAttack data to the base ruleset so new games load the same unit prototype behavior.
• Add focused tests for normal facing, broadside facing, save conversion, and base-ruleset entries.

Fixes #902.

Testing

• Created a loadable save file with two Frigates on adjacent coast tiles, loaded it in OpenCiv3, and fought the ships to check the firing direction.
• dotnet build C7/C7.sln
• dotnet format C7/C7.sln whitespace --verify-no-changes
• dotnet test C7/C7.sln with CIV3_HOME set: 62 passed
• git diff --check
• dotnet list C7/C7.sln package --vulnerable --include-transitive: no vulnerable packages

[ajhalme]

Thanks, looks pretty good.

A few issues, I've submitted a patch on your branch here: richardspink2#1

• The rotation should be CCW (did you test this at all?)
• For this new unit property rotateBeforeAttack to function correctly in a new game, the unit prototypes in the "base ruleset" need to be told about it.
• And finally, the merge issue here is due to a recent merge on Development

[richardspink2]

Thanks for catching that. I did test it with a loadable save containing two adjacent Frigates, but I was checking the broadside behavior rather than the handedness of the rotation. I’ve corrected it to CCW, added the base-ruleset entries, rebased on latest Development, and added automated coverage so this no longer depends on visual inspection.

[stavrosfa]

Thanks, looks good overall!

[stavrosfa]

Don't hate me for this @richardspink2, usually I am not that slow, but I totally missed this up until now.

This is the first, (if I am not completely mistaken) of what the editor calls Unit Abilities, to be implemented.

I think the best way to go about this, is to have these as flags, similar to what buildings do

e.x.

For 1 such ability, having boolean fields is not such a big deal, but there are 31 abilities * 124 unit prototypes = 3844 fields, with mostly grabage information.

I don't know if that makes sense to you both.

[richardspink2]

That makes sense. I updated this to use a unit prototype flag instead of a saved boolean field, matching the existing building/tech flag pattern. The runtime still has a rotateBeforeAttack convenience property backed by the flag, and the base ruleset now only marks the TurnToAttack units with flags: ["rotateBeforeAttack"] instead of carrying false values for every other unit.

[ajhalme]

LGTM, working fine.

[stavrosfa]

Thanks, looking great overall!