Skip to content

[FIX] Prevent creation of empty per-stream subtitle files #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VyankateshD206 wants to merge 1 commit into from
Closed

[FIX] Prevent creation of empty per-stream subtitle files #1832

VyankateshD206 wants to merge 1 commit into from

Conversation

@VyankateshD206
Copy link

@VyankateshD206 VyankateshD206 commented Dec 15, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

[FIX] Prevent creation of empty per-stream subtitle files (Fixes #1282)

This pull request implements deferred output file creation to avoid producing zero-byte .srt files for caption streams that contain no actual data.

  • Track per-output writes via wrote_data on ccx_s_write.
  • When no data is written to an output, skip footer writing and delete the file on teardown to avoid empty cc3 artifacts.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Dec 15, 2025

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit b728dda...:
Report Name Tests Passed
Broken 5/13
CEA-708 13/14
DVB 7/7
DVD 0/3
DVR-MS 2/2
General 5/27
Hardsubx 0/1
Hauppage 0/3
MP4 3/3
NoCC 10/10
Options 73/86
Teletext 20/21
WTV 4/13
XDS 25/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Dec 15, 2025

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b728dda...:
Report Name Tests Passed
Broken 4/13
CEA-708 13/14
DVB 6/7
DVD 0/3
DVR-MS 2/2
General 5/27
Hardsubx 0/1
Hauppage 0/3
MP4 3/3
NoCC 10/10
Options 71/86
Teletext 21/21
WTV 0/13
XDS 25/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:

  • ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Never
  • ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Never
  • ccextractor --out=txt c83f765c66..., Last passed: Never
  • ccextractor --out=spupng c83f765c66..., Last passed: Never
  • ccextractor --unixts 5 --out=txt c83f765c66..., Last passed: Never
  • ccextractor --out=txt --datets c83f765c66..., Last passed: Never
  • ccextractor --out=txt --sects c83f765c66..., Last passed: Never
  • ccextractor --out=txt --lf c83f765c66..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Never

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

@cfsmp3
Copy link
Contributor

cfsmp3 commented Dec 31, 2025

Thank you for working on this issue. Unfortunately, the Sample Platform CI shows 47 test failures across multiple categories (Broken, CEA-708, General, Hardsubx, Hauppauge, Options, WTV, XDS), indicating that this approach causes significant regressions.

The wrote_data tracking approach is interesting, but it's interfering with the normal output flow in ways that break existing functionality.

We have an alternative approach in PR #1877 that handles this more simply by deleting empty files after the encoding process completes, rather than trying to track writes during encoding. This avoids the complexity and regressions.

I'm closing this PR in favor of #1877. Thank you for your contribution - the effort is appreciated!

@cfsmp3 cfsmp3 closed this Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

empty 608 cc3 caption generating with option -12

3 participants

@VyankateshD206 @ccextractor-bot @cfsmp3