Skip to content

Enhanced Timer by adding new feature #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

nidhin29
Copy link
Contributor

@nidhin29 nidhin29 commented Mar 3, 2024

Description

The timer is enhanced by adding pomodoro feature

Proposed Changes

Android.Emulator.-.Pixel_3a_API_33_x86_64_5554.2024-03-03.20-12-44.mp4

Fixes #156

@nidhin29
Copy link
Contributor Author

nidhin29 commented Mar 3, 2024

@MarkisDev Sir, I had some misunderstandings I have added the pomodoro feature as expected

@nidhin29
Copy link
Contributor Author

nidhin29 commented Mar 3, 2024

@MarkisDev Sir, is this fine

@MarkisDev
Copy link
Member

This definitely does work, but I think we need a switch or something to allow the user to switch to a pomodoro timer. We aren't looking to replace the timer, just add onto it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably add a switch which when enabled can turn the normal timer into a pomodoro style. Otherwise, it'll function as a normal timer.

@nidhin29
Copy link
Contributor Author

@MarkisDev Sir, I understand what you said but what i have done is that if the break time is zero then it will function as a normal timer otherwise pomodoro

@MarkisDev
Copy link
Member

@MarkisDev Sir, I understand what you said but what i have done is that if the break time is zero then it will function as a normal timer otherwise pomodoro

That would just make things more confusing for a person who wants to use the normal timer. We should just hide the break section for a pomodoro timer unless its necessary.

@nidhin29
Copy link
Contributor Author

@MarkisDev Ok Sir

@nidhin29 nidhin29 closed this Mar 16, 2024
@nidhin29 nidhin29 force-pushed the Pomodoro-feature3 branch from 52a4464 to b845af6 Compare March 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Adding Stopwatch and Pomodoro functionality
2 participants