Skip to content

maxSnoozeCount Feature Implementation #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mahendra-918
Copy link
Contributor

@mahendra-918 mahendra-918 commented Apr 12, 2025

Description

This PR fixes the issue with the maxSnoozeCount setting not being properly saved and retrieved from the database.

Proposed Changes

-Added the maxSnoozeCount column to the SQLite database schema in IsarDb.onCreate
-Updated the Isar database schema by regenerating it using build_runner
-Added a database fix routine (fixMaxSnoozeCountInAlarms) that ensures all alarms have the correct maxSnoozeCount value
-Added code in AlarmRingController to verify and ensure the maxSnoozeCount is correctly loaded from the database
-Fixed the startSnooze method to properly check against the actual maxSnoozeCount from the database
-Ensured the value is correctly passed through all necessary components

Screenshots

WhatsApp.Video.2025-04-12.at.22.34.57.mp4

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@mahendra-918
Copy link
Contributor Author

Hi @MarkisDev , can you please review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant