Skip to content

fix: error in alarm creation resolved #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Antrimo
Copy link
Contributor

@Antrimo Antrimo commented Apr 24, 2025

Description

When the user used to delete an alarm then the onClose() was called to Dispose all the controllers, and therefore when creating a new alarm, there was no controller available and hence the Error.

Proposed Changes

  • deleting the existing controller eveytime
  • a new InputTimeController each time AddOrUpdateAlarmView is created ensures fresh TextEditingController

Fixes #831

Screenshots

WhatsApp.Video.2025-04-24.at.12.58.17.mp4
WhatsApp.Video.2025-04-24.at.19.54.52.mp4

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@Antrimo
Copy link
Contributor Author

Antrimo commented Apr 24, 2025

hey @MarkisDev
Could you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Error in Alarm Creation after Deletion of any Alarm
1 participant