CNDE-2226: Bmird_strep_pneumo datamart postprocessing proc #233
+3,535
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johneipe
requested review from
sveselev,
joshua-mills-cdw and
upasanapattnaik-eq
and removed request for
sveselev and
joshua-mills-cdw
sveselev
changed the title
sveselev
reviewed
Mar 11, 2025
...c/main/java/gov/cdc/etldatapipeline/postprocessingservice/service/PostProcessingService.java
Show resolved
Hide resolved
# Conflicts: # liquibase-service/src/main/resources/db/changelog/db.rdb_modern.changelog-16.1.yaml
db/upgrade/rdb_modern/routines/045-sp_bmird_strep_pneumo_datamart_postprocessing.sql
Show resolved
Hide resolved
sveselev
reviewed
Mar 12, 2025
db/upgrade/rdb_modern/tables/061-create-bmird_strep_pneumo_datamart.sql
Outdated
Show resolved
Hide resolved
sveselev
reviewed
Mar 12, 2025
...c/main/java/gov/cdc/etldatapipeline/postprocessingservice/service/PostProcessingService.java
Show resolved
Hide resolved
sveselev
reviewed
Mar 12, 2025
.../test/java/gov/cdc/etldatapipeline/postprocessingservice/service/DatamartProcessingTest.java
Outdated
Show resolved
Hide resolved
sveselev
reviewed
Mar 12, 2025
...st/java/gov/cdc/etldatapipeline/postprocessingservice/service/PostProcessingServiceTest.java
Show resolved
Hide resolved
sveselev
reviewed
Mar 12, 2025
...st/java/gov/cdc/etldatapipeline/postprocessingservice/service/PostProcessingServiceTest.java
Show resolved
Hide resolved
sveselev
reviewed
Mar 12, 2025
post-processing-service/src/test/resources/rawDataFiles/BMIRDStrepDatamart.json
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Bmird_strep_pneumo datamart postprocessing procedure and service integration.
JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle buildpass in your local?gradle buildlogs attached?