more tests - #241
Merged
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CloudClient tests to accommodate recent add_task behavior changes around resolving container images from pool configuration, and to keep DAG execution tests passing.
Changes:
- In
test_add_task, adds a mocked pool configuration viaget_pool_full_infosoadd_task()can resolve a default container image when none is provided. - In
test_run_dag, setsfull_container_namebefore running the DAG to avoid container resolution failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
cfa/cloudops/scripts.py:1177
--file_pathis a required CLI argument but it has nohelp=text, soadd_tasks_from_yaml --helpwon’t describe what the flag is for. Adding a short description improves the CLI UX and keeps it consistent with the other arguments in this parser.
"-fp",
"--file_path",
type=str,
required=True,
)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ryanraaschCDC
marked this pull request as ready for review
July 27, 2026 18:04
xop5
approved these changes
Jul 30, 2026
Collaborator
|
Please resolve the merge conflict |
xop5
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.