generated from CDCgov/template
-
Couldn't load subscription status.
- Fork 0
Legend In Plots #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
O957
wants to merge
36
commits into
main
Choose a base branch
from
117-legend-in-plots
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Legend In Plots #119
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
6bc9e1a
space removal
O957 7990fd3
Merge remote-tracking branch 'origin/main' into 117-legend-in-plots
O957 8f16fd0
try color encoding
O957 8cda371
Merge remote-tracking branch 'origin/main' into 117-legend-in-plots
O957 83015c3
Merge remote-tracking branch 'origin/main' into 117-legend-in-plots
O957 2becfc8
attempt to use color scale for target data and forecast charts
O957 61ac0bf
good enough legend
O957 7185da2
fix marker size
O957 4bd04e2
CI labels
O957 5624d75
minor corrections
O957 1cdba52
Merge remote-tracking branch 'origin/main' into 117-legend-in-plots
O957 043dd46
minor update
O957 7ba3e72
remove comment
O957 2adb8db
still some issues
O957 bf0074b
Merge remote-tracking branch 'origin/main' into 117-legend-in-plots
O957 a2e9535
add legend atop
O957 8530a62
different attempt
O957 6c1736c
finally nice
O957 a8dd896
add colorbrewer
O957 dffa4d9
Merge remote-tracking branch 'origin/main' into 117-legend-in-plots
O957 90cb0d2
colorbrewer use
O957 527adba
add mpl
O957 c8d2ded
ci spec items
O957 fe3e833
clean plotting ui a bit
O957 cb8b5ab
update build from df
O957 c823da8
clean up wide df
O957 50b57b2
remove unecessary items
O957 bc0cbc2
no quantile levels
O957 80852ad
rename func to verb
O957 59d3d20
redo ci pairs
O957 7d9ba4c
format percent from babel
O957 2a911de
max num cis
O957 8b57127
Merge remote-tracking branch 'origin/main' into 117-legend-in-plots
O957 2be5c6c
try use existing define scheme
O957 53764a5
vega scheme
O957 89b6a47
deptry fix
O957 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure overall feels a bit off.
What about
get_available_ci(list_of_quantiles)which returns all of the available ci's (width only, or width, lower, and upper)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Get the colors" step may be obviated by https://vega.github.io/vega/docs/schemes/#blues