Compute max as_of over target
#144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the change you made seem to fix all of the ways in which the PR (not sure if you're referring to this PR) is broken? (I am not sure how to replicate the breakage). I've approved the PR, but please do verify that the answer to the question above is Yes. |
O957
approved these changes
Aug 13, 2025
|
This PR currently has a bug. I will provide steps to reproduce. Would appreciate if you could take over and find a fix @AFg6K7h4fhy2 |
Sounds good, I will examine this, probably a bit later today. |
|
Seems like this should be a forecasttools-py function. See also forecasttools-R CDCgov/forecasttools#199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different targets can have different maximum
as_ofdates.Current PR seems to be broken at times: