Skip to content

Conversation

@tretre91
Copy link
Member

@tretre91 tretre91 commented Nov 8, 2025

This PR adds a SplineEvaluatorND class working in any number of dimensions. Currently, the template arguments to the class and to the methods are passed using TypeSeqs, and the aliases alias_1, alias_2, etc are replaced by templated equivalents alias<0>, alias<1>, etc.

The tests for this are just the 3D spline test and one of the 1D spline test modified to use the ND evaluator. We might want to factorize some of the test code or use the same test files with some #ifdefs to enable the ND or regular Evalutor

@tretre91 tretre91 changed the title ND Spline ND Spline Evaluator Nov 8, 2025
@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 77.27273% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.41%. Comparing base (23760f3) to head (cb175b3).

Files with missing lines Patch % Lines
...nclude/ddc/kernels/splines/spline_evaluator_nd.hpp 76.56% 10 Missing and 5 partials ⚠️

❌ Your patch check has failed because the patch coverage (77.27%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
- Coverage   91.76%   91.41%   -0.35%     
==========================================
  Files          57       58       +1     
  Lines        2756     2820      +64     
  Branches      924      954      +30     
==========================================
+ Hits         2529     2578      +49     
- Misses        136      146      +10     
- Partials       91       96       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to declare the new header file in the target_sources to make the installation test pass

- Make the DerivDims template argument non-variadic
- Add tests for one of the deriv_dim_I overloads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants