-
Notifications
You must be signed in to change notification settings - Fork 9
ND Spline Evaluator #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ND Spline Evaluator #967
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (77.27%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
==========================================
- Coverage 91.76% 91.41% -0.35%
==========================================
Files 57 58 +1
Lines 2756 2820 +64
Branches 924 954 +30
==========================================
+ Hits 2529 2578 +49
- Misses 136 146 +10
- Partials 91 96 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpadioleau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to declare the new header file in the target_sources to make the installation test pass
- works for host backends for the moment
- test the 1d ND evaluator - rename the 3d test file
40adb73 to
fab1202
Compare
- Make the DerivDims template argument non-variadic - Add tests for one of the deriv_dim_I overloads
This PR adds a SplineEvaluatorND class working in any number of dimensions. Currently, the template arguments to the class and to the methods are passed using
TypeSeqs, and the aliasesalias_1, alias_2, etcare replaced by templated equivalentsalias<0>, alias<1>, etc.The tests for this are just the 3D spline test and one of the 1D spline test modified to use the ND evaluator. We might want to factorize some of the test code or use the same test files with some
#ifdefs to enable the ND or regular Evalutor