Skip to content

New package: Feature graph#9465

Draft
ange-clement wants to merge 12 commits intoCGAL:mainfrom
ange-clement:Feature_graph-aclement
Draft

New package: Feature graph#9465
ange-clement wants to merge 12 commits intoCGAL:mainfrom
ange-clement:Feature_graph-aclement

Conversation

@ange-clement
Copy link
Copy Markdown
Member

@ange-clement ange-clement commented May 6, 2026 •
edited
Loading

Summary of Changes

New package "Feature graph" that contains methods to extract sharp features from 3D images.

Tasks

  • Validate API
  • Integrate code
  • Test
  • Manual and examples

Release Management

  • Affected package(s):
  • Issue(s) solved (if any):
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature)
  • License and copyright ownership:

@ange-clement
Feature graph initial commit
c7fe36a
@ange-clement
Initial API for Feature graph
f3c299e
@ange-clement
Updated API for Feature graph
dee6f63
@ange-clement
API Changes
6953ea2 
Feature graph is now an VertexAndEdgeListGraph
Lowercase in passive form
in --> on
regularization isthmus distance parameter
Element type is now CGAL::Dimension_tag
@ange-clement
Regularization parameters
b85a0b7
@ange-clement
Fix missing quote + Use stars for doc
bf7c751
albert-github
albert-github reviewed May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@albert-github albert-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be /// @{ instead of // @{

occurs in multiple files.

(I didn't really review it but this caught my eye)

@ange-clement
Copy link
Copy Markdown
Member Author

ange-clement commented May 6, 2026

Feature_graph

@lrineau
Copy link
Copy Markdown
Member

lrineau commented May 7, 2026

/build:doc-wip

@lrineau lrineau added Not yet approved The feature or pull-request has not yet been approved. Work in progress labels May 7, 2026
@lrineau lrineau changed the title Feature graph: Package creation New package: Feature graph May 7, 2026
@ange-clement
Temporarily moved doc folder
106d1bb 
It will be placed back once the API is validated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

There was an error while building the doc:

/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/PackageDescription.txt:42: warning: unable to resolve reference to 'PkgDEPENDENCY' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/detect_sharp_features.h:26: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/detect_sharp_features.h:30: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/detect_sharp_features.h:91: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:171: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:173: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:171: warning: argument 'plane_detection_distance' of command @param is not found in the argument list of CGAL::Optimization_parameters_on_image< NormalEstimator >::Optimization_parameters_on_image(const NamedParameters &np=parameters::default_values())
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:171: warning: argument 'normal_estimator' of command @param is not found in the argument list of CGAL::Optimization_parameters_on_image< NormalEstimator >::Optimization_parameters_on_image(const NamedParameters &np=parameters::default_values())
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:274: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:276: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:274: warning: argument 'plane_detection_distance' of command @param is not found in the argument list of CGAL::Optimization_parameters_on_surface< NormalEstimator >::Optimization_parameters_on_surface(const NamedParameters &np=parameters::default_values())
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:274: warning: argument 'normal_estimator' of command @param is not found in the argument list of CGAL::Optimization_parameters_on_surface< NormalEstimator >::Optimization_parameters_on_surface(const NamedParameters &np=parameters::default_values())
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/regularization_parameters.h:102: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/regularization_parameters.h:104: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/regularization_parameters.h:212: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/regularization_parameters.h:214: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/Feature_graph.txt:22: warning: unable to resolve reference to '\n' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/Feature_graph.txt:22: warning: unexpected token TK_COMMAND_BS as the argument of include
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/Feature_graph.txt:24: warning: image file bench.png is not found in IMAGE_PATH: assuming external image.
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/Feature_graph.txt:24: warning: image file bench.png is not found in IMAGE_PATH: assuming external image.
Error: Figure numbering; fig__figPck has not been collected

https://github.com/CGAL/cgal/actions/runs/25483628171

@ange-clement
Copy link
Copy Markdown
Member Author

ange-clement commented May 7, 2026

/build:doc-wip

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9465/doc/Manual/index.html

@ange-clement
Copy link
Copy Markdown
Member Author

ange-clement commented May 7, 2026

/build:doc-wip

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9465/doc/Manual/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@albert-github albert-github albert-github left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Not yet approved The feature or pull-request has not yet been approved. Work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ange-clement @lrineau @albert-github