Prevent selection change for external endpoints in changeSelected.#302
Merged
RobotHanzo merged 1 commit intoCKStudentCouncil:mainfrom Mar 11, 2026
Merged
Prevent selection change for external endpoints in changeSelected.#302RobotHanzo merged 1 commit intoCKStudentCouncil:mainfrom
changeSelected.#302RobotHanzo merged 1 commit intoCKStudentCouncil:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the sidebar selection logic so that clicking an external endpoint (opened via href/target="_blank") no longer updates the app’s internal “selected” state, keeping selection restricted to internal routes.
Changes:
- Add an
externalendpoint guard inchangeSelectedto early-return for external endpoints.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small update to the
changeSelectedfunction inHeaderSidebar.vue. Now, when a user attempts to select an external endpoint, the selection is prevented, ensuring only internal endpoints can be selected.changeSelectedfunction by checking theexternalproperty before updating the selected value.