[WIP] Visualisation Backend #406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/export_api_v0.1.0.md
Outdated
| This document defined the API used for exporting data from Raft | ||
|
|
||
| ## Enabling Exporting ## | ||
| By default the exporting function is off, to turn it on `pfsd` must be ran with |
Member
Author
There was a problem hiding this comment.
I always make that mistake :) thanks
VoyTechnology
force-pushed
the
feature/voy/visualisation-backend
branch
2 times, most recently
from
e256465 to
47e910e
Compare
…on of sending and receiving data
raft/configuration.go
Outdated
| Uuid: nodes[i].NodeID, | ||
| CommonName: nodes[i].CommonName, | ||
| State: "unknown", | ||
| Addr: nodes[i].IP+nodes[i].Port, |
Member
Author
There was a problem hiding this comment.
Just noticed I am missing : here. Will add in next commit
pfsd/main.go
Outdated
| if(*exportFlag){ | ||
| raft.EnableExporting = true | ||
| exporter.NewStdServer(*exportPortFlag); | ||
| go exporter.Listen(); |
There was a problem hiding this comment.
This should be added to a wait group.
raft/raft.go
Outdated
|
|
||
| func (s *RaftNetworkServer) sendLeaderDataRequest() { | ||
| // TODO: Proper Implementation with channels | ||
| s.Wait.Done() |
…file in raft containing all the exporting functions
raft/exporter.go
Outdated
| for i := 0; i < len(nodes); i++ { | ||
| detailedNodes = append(detailedNodes, &pb.LeaderData_Data_DetailedNode{ | ||
| Uuid: nodes[i].NodeID, | ||
| CommonName: nodes[i].CommonName, |
Member
Author
There was a problem hiding this comment.
sigh
I blame bad habits that go-plus created by formatting for me....
| client := pb.NewRaftNetworkClient(conn) | ||
| stream, err := client.RequestLeaderData(context.Background(), &pb.LeaderDataRequest{}) | ||
| if err != nil { | ||
| Log.Error("Unable to request user data") |
There was a problem hiding this comment.
This should not just continue if this fails.
| return errors.New("Node is not leader") | ||
| } | ||
| for { | ||
| select { |
There was a problem hiding this comment.
This probably needs to respect the quit channel in some way, otherwise it will just run for ever.
Also, maybe it should add itself to the wait group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend for the visualisation
Relates to #387 and #383