Keep printliminated sections on screen and add keyboard shortcut Alt+Delete to remove hidden sections from the DOM#28
Open
odebroqueville wants to merge 3 commits intoCSS-Tricks:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I apologize with the formatting issues I've had that make it difficult to see the changes that I made to your code! I made these changes so that Printliminator would be compatible with Omnivore's web clipper, so that printliminated sections don't get saved to Omnivore.
I replaced event.which (which is deprecated) with event.key, and therefore also changed the keys object. I also added an entry for remove: to be able to remove the hidden sections from the DOM.
I also added the function removeHidden() which removes the hidden sections from the DOM.
When running grunt --force, I got some warnings I don't understand but nothing too bad as the changes are working.
Last but not least, I hope you'll consider transforming this useful extension to manifest v3 as Google will be deprecating mv2 come June.