Another pass at speeding up CFCML #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should take npbc_arrayProgTheory from 32m to 23m (speedup: 9m). Also inlined some stuff into xlet_core; partly for making profiling easier, and partly just because ¯\_(ツ)_/¯
ordinarymath
reviewed
Nov 9, 2025
Seems to lead to a speedup of around 2 minutes in npbc_arrayProg
I think this is around 29s in npbc_arrayProg
No need to manually create the tactic version if it already exists.
dnezam
force-pushed
the
speedup-npbc_arrayProg
branch
from
1a97a29 to
cbd6bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimizations were mainly guided by looking at hotspots in
npbc_arrayProgusing the profiler. The speedup for it seems to be 10 minutes (32m => 22m). The proofs now take around 10 minutes; the rest is other stuff (probably translation; maybe that should also be profiled in the future).Also,
TextIOProofnow takes a bit over 7 minutes.