Add args argument to REPLWrapper & spawn() to mimic pty_spawn#281
Closed
tikuma-lsuhsc wants to merge 2 commits intoCalysto:mainfrom
Closed
Add args argument to REPLWrapper & spawn() to mimic pty_spawn#281tikuma-lsuhsc wants to merge 2 commits intoCalysto:mainfrom
args argument to REPLWrapper & spawn() to mimic pty_spawn#281tikuma-lsuhsc wants to merge 2 commits intoCalysto:mainfrom
Conversation
in the same manner as pt_ spawn does
blink1073
added a commit
to blink1073/metakernel
that referenced
this pull request
Mar 14, 2026
…h spaces (closes Calysto#281) Adds an `args` list parameter to `REPLWrapper.__init__` and passes it through to `pexpect.spawnu`. On the non-pty (Windows) codepath, the command is no longer shlex-split when `args` is explicitly provided, matching the pty_spawn behaviour and allowing executable paths containing spaces to work correctly.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR originates from the issue related to my recent PR to
octave_kernel[Re: space in the octave executable path in Windows].This PR contains two commits:
e800dca: This commit adds
argslist argument to theREPLWrapperconstructor so it can be passed down tospawn. A test method has also been added totest_replwrap.py.303f2fd:
pty_spawnand non-pty_spawncodepaths currently handlescommandandargsdifferently. This commit makes the non-ptypath to be comparable to thepty_spawnimplementation. That is,commandis only split only ifargsis not provided.These two mechanisms are essential to allow an octave executable path with spaces to run in Windows. If this PR is accepted, I will create another PR in
octave_kernelto finish resolving the issue.Thanks