Improve the Footer #486
Open
Improve the Footer #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🎊 PR Preview 4af7b6a has been successfully built and deployed to https://CarletonComputerScienceSociety-website-build_preview-pr-486.surge.sh 🕐 Build time: 0.009s
🤖 By surge-preview |
ryangchung
requested changes
Jun 5, 2024
Collaborator
ryangchung
left a comment
ryangchung
left a comment
There was a problem hiding this comment.
I think the pin could be smaller, and aligned to the line. Also, on hover, the address could show underlined and can also be clicked to go to the google maps link.
cc @MathyouMB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the footer, pin icon opens up google maps to Herzberg Laboratories and the email icon opens up email. Let me know if something doesn't look right